mgr/cephadm: Handle empty optional spec values in add_mds #33222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec.placement.count and spec.placement.hosts need to be filled for add_mds to be successful Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
|
I think a simpler fix is to change volumes to call update_mds instead of add_mds... |
|
IMO the problem is that there is no way to specify any placements when calling |
sebastian-philipp
suggested changes
Feb 12, 2020
Comment on lines
+1936
to
+1941
| spec.placement.count = spec.count | ||
|
|
||
| if not spec.placement.hosts: | ||
| spec = NodeAssignment(spec=spec, get_hosts_func=self._get_hosts, service_type='mds').load() | ||
|
|
||
| if len(spec.placement.hosts) < spec.placement.count: |
|
closing in favor of #33441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.placement.count and spec.placement.hosts need to be filled for add_mds to be successful
Fixes: https://tracker.ceph.com/issues/43835
Signed-off-by: Daniel-Pivonka dpivonka@redhat.com