mgr/dashboard: coverage venv python version same as mgr #33407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ceph#31525 is merged, coverage dep. in run-backend-api-tests.sh has to be installed in venv with the same python version as ceph-mgr. Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
requested review from
tchaikov,
votdev,
sebastian-philipp and
callithea
|
jenkins test dashboard backend |
tchaikov
requested changes
Feb 19, 2020
tchaikov
approved these changes
Feb 19, 2020
callithea
approved these changes
Feb 19, 2020
|
"ceph dashboard backend API tests " failure is unrelated to this PR as it is also detected on master. |
|
jenkins test dashboard backend |
alfonsomthd
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 9, 2020
As we cannot backport directly ceph#33407 to nautilus and COVERAGE_PATH is invalid for CentOS7 + py2, this fix is applied directly to nautilus. Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 9, 2020
As we cannot backport directly ceph#33407 to nautilus and COVERAGE_PATH is invalid for CentOS7 + py2, this fix is applied directly to nautilus. Signed-off-by: Alfonso Martínez <almartin@redhat.com>
3 tasks
alfonsomthd
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 16, 2020
As we cannot backport directly ceph#33407 to nautilus and COVERAGE_PATH is invalid for CentOS7 + py2, this fix is applied directly to nautilus. Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Apr 16, 2020
As we cannot backport directly ceph#33407 to nautilus and COVERAGE_PATH is invalid for CentOS7 + py2, this fix is applied directly to nautilus. Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #31525 is merged,
coverage dep. in run-backend-api-tests.sh has to be installed in venv
with the same python version as ceph-mgr.
Signed-off-by: Alfonso Martínez almartin@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox