Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: fail when get/set-bucket-versioning attempted on a non-existent … #33521

Merged
merged 1 commit into from Jun 8, 2020
Merged

rgw: fail when get/set-bucket-versioning attempted on a non-existent … #33521

merged 1 commit into from Jun 8, 2020

Conversation

mattbenjamin
Copy link
Contributor

@mattbenjamin mattbenjamin commented Feb 24, 2020 •
edited

…bucket

These should not succeed, but fail w/HTTP 404 and NoSuchBucket as
the API error.

Fixes: https://tracker.ceph.com/issues/44280

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mattbenjamin
rgw: fail when get/set-bucket-versioning attempted on a non-existent …
350dd30 
…bucket

These should not succeed, but fail w/HTTP 404 and NoSuchBucket as
the API error.

Fixes: https://tracker.ceph.com/issues/44280

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin mattbenjamin self-assigned this Feb 24, 2020
theanalyst
theanalyst approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@theanalyst theanalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@ivancich ivancich added wip-eric-testing-2 for ivancich testing wip-eric-testing-1 for ivancich testing and removed wip-eric-testing-2 for ivancich testing labels Jun 8, 2020
@ivancich
Copy link
Member

ivancich commented Jun 8, 2020

QA results:

@ivancich ivancich merged commit 4c632f0 into ceph:master Jun 8, 2020
@ivancich ivancich removed needs-qa wip-eric-testing-1 for ivancich testing labels Jun 8, 2020
@smithfarm smithfarm mentioned this pull request Jul 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dang dang dang approved these changes

@theanalyst theanalyst theanalyst approved these changes

@cbodley cbodley Awaiting requested review from cbodley

Assignees

@mattbenjamin mattbenjamin

Labels
bug-fix rgw
Projects
None yet
Milestone
No milestone
5 participants
@mattbenjamin @ivancich @dang @theanalyst @cbodley