formatter: improve pretty output, rename factory method #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to json-pretty and xml-pretty modes. Signed-off-by: Sage Weil <sage@inktank.com>
The whitespace for the current pretty mode is awkward and weird. Move to a more standard approach. It's more newlines, but *much* more readable. Signed-off-by: Sage Weil <sage@redhat.com>
Also make the default formatter selection more explicit. Signed-off-by: Sage Weil <sage@redhat.com>
|
FAIL: the output of run-make-check.sh on centos-centos7 for 35eb1b4 is http://paste2.org/MCFdJMfU |
Sent from
|
FAIL: the output of run-make-check.sh on centos-centos7 for a3507ea is http://paste2.org/W7jC4Akn |
|
both make check run timeout |
|
Thanks for investigating the failures @dachary |
|
While I certainly don't really understand the formatting changes to json-pretty (comments? are you mad?), the overall changes look good to me. |
dmick
added a commit
that referenced
this pull request
Jan 14, 2015
formatter: improve pretty output, rename factory method Reviewed-by: Dan Mick <dan.mick@redhat.com>
|
@dachary it looks this series affect master branch UT robot. |
|
@yuyuyu101 yes, master is now broken http://tracker.ceph.com/issues/10547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go from this:
root@mira040:~# ceph osd find 0 { "osd": 0, "ip": "10.214.133.134:6810\/1679", "crush_location": { "host": "mira040", "root": "default"}}root@mira040:~#to this:
maetl:src (wip-formatter) 08:10 AM $ ./ceph osd find 0 { "osd": 0, "ip": "127.0.0.1:6806\/7906", "crush_location": { "host": "maetl", "root": "default" } } maetl:src (wip-formatter) 08:57 AM $