Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] mgr/orchestrator: add spec_presence in ServiceDescription.to_json() #33685

Closed
wants to merge 1 commit into from
Closed

[WIP] mgr/orchestrator: add spec_presence in ServiceDescription.to_json() #33685

wants to merge 1 commit into from

Conversation

bk201
Copy link
Contributor

@bk201 bk201 commented Mar 3, 2020

Include key spec_presence and its value in the JSON output.

  • Fix the inconsistency between orch ls and orch ls --format=json.
  • Dashboard/API clients can display this column.

Fixes: https://tracker.ceph.com/issues/44392
Signed-off-by: Kiefer Chang kiefer.chang@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@bk201
mgr/orchestrator: add spec_presence in ServiceDescription.to_json()
b96359f 
Include key `spec_presence` and its value in the JSON output.
- Fix the inconsistency between `orch ls` and `orch ls --format=json`.
- Dashboard/API clients can display this column.

Fixes: https://tracker.ceph.com/issues/44392
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201 bk201 requested a review from a team as a code owner March 3, 2020 10:12
@bk201 bk201 requested a review from jschmid1 March 3, 2020 10:12
@bk201 bk201 mentioned this pull request Mar 3, 2020
Merged
3 tasks
@liewegas
Copy link
Member

liewegas commented Mar 3, 2020

Note that there is another change coming here, too: #33667

  • spec_presence -> spec (the actual ServiceSpec)
  • the CLI adds a PLACEMENT column (str(spec.placement))

@bk201 bk201 added the DNM label Mar 4, 2020
@bk201 bk201 changed the title mgr/orchestrator: add spec_presence in ServiceDescription.to_json() [WIP] mgr/orchestrator: add spec_presence in ServiceDescription.to_json() Mar 4, 2020
@bk201
Copy link
Contributor Author

bk201 commented Mar 6, 2020

Close this in favor of #33779

@bk201 bk201 closed this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschmid1 jschmid1 Awaiting requested review from jschmid1

Assignees
No one assigned
Labels
bug-fix DNM orchestrator
Projects
None yet
Milestone
No milestone
2 participants
@bk201 @liewegas