mgr/rbd_support: don't scan pools that don't have schedules #33840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Golub <mgolub@suse.com>
|
Not 100% sure if it's related to this PR, but the CLI tests are failing now: |
|
@dillaman there was a race in the cli test -- it did not wait for schedule status updated. Pushed the fix as an additional commit. |
Signed-off-by: Mykola Golub <mgolub@suse.com>
trociny
force-pushed
the
wip-schedule-optimize-scan
branch
from
08098ff
to
5c80c49
Compare
For the case when the non-global level does not have a schedule and a higher level is used as the parent, it wrongly listed schedules from all branches under the parent, instead of only the interested one. Signed-off-by: Mykola Golub <mgolub@suse.com>
|
@dillaman when looking at that test failure I noticed an issue with the recursive schedule listing, which I fixed in the last pushed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Golub mgolub@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox