Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: delete full sync index before switching to incremental sync #33934

Merged
merged 2 commits into from Jan 18, 2022

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 12, 2020

the full sync index is stored in omap, and isn't needed after full sync completes. keeping them around also causes issues with data sync init/metadata sync init, because they add to this existing/stale index instead of replacing it

Fixes: https://tracker.ceph.com/issues/40177

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@cbodley
Copy link
Contributor Author

cbodley commented May 5, 2020

@stale
Copy link

stale bot commented Jul 4, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 4, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@stale stale bot closed this Oct 4, 2020
@smanjara
Copy link
Contributor

smanjara commented Oct 5, 2020

@cbodley I missed this one, sorry. Should we reopen or is it going to be part of the ongoing multisite work?

@cbodley cbodley reopened this Oct 5, 2020
@stale stale bot removed the stale label Oct 5, 2020
@cbodley
Copy link
Contributor Author

cbodley commented Oct 5, 2020

@smanjara yes would still like to get this tested and merged!

src/rgw/rgw_data_sync.cc Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Dec 13, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 21, 2021
Fixes: https://tracker.ceph.com/issues/40177

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Fixes: https://tracker.ceph.com/issues/40177

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@stale stale bot removed the stale label Jan 17, 2022
@cbodley cbodley added the needs-quincy-backport backport required for quincy label Jan 18, 2022
@cbodley cbodley merged commit e11654d into ceph:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants