Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/rbd: ensure image is open before permitting operations #34112

Merged
merged 1 commit into from Mar 31, 2020

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Mar 23, 2020

Fixes: https://tracker.ceph.com/issues/44610
Signed-off-by: Mykola Golub mgolub@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@trociny
Copy link
Contributor Author

trociny commented Mar 23, 2020

I suppose a much cleaner solution would be just to remove close method (forbid public access) but it would break API.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- I probably would have used a decorator, but this matches the rados style.

@trociny
Copy link
Contributor Author

trociny commented Mar 23, 2020

@dillaman I tried with a decorator and it really looks nicer for me, so I updated the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants