Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octopus: cephadm: Fix truncated output of "ceph mgr dump" #34258

Merged
merged 1 commit into from Mar 29, 2020
Merged

octopus: cephadm: Fix truncated output of "ceph mgr dump" #34258

merged 1 commit into from Mar 29, 2020

Conversation

sebastian-philipp
Copy link
Contributor

Backport of #34215

Original description:

i.e. don't call poll() while we still can read a lot of output

@tim this fixes the truncated output for me. wdyt?

This is an alternative for #34031

Fixes: https://tracker.ceph.com/issues/44642
Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp
cephadm: Fix trucated output of mgr dump
10e892c 
In case the process has terminated, we
have to make sure to read till EOF, otherwise
we might skip some bytes.

Fixes: https://tracker.ceph.com/issues/44642

Co-authored-by: Tim Serong <tserong@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit 6a6759e)
@sebastian-philipp sebastian-philipp requested a review from a team as a code owner March 28, 2020 00:21
@sebastian-philipp sebastian-philipp added this to the octopus milestone Mar 28, 2020
@liewegas liewegas merged commit c01a235 into ceph:octopus Mar 29, 2020
@smithfarm smithfarm changed the title octopus: cephadm: Fix trucated output of mgr dump octopus: cephadm: Fix truncated output of "ceph mgr dump" Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
cephadm wip-sage-testing
Projects
None yet
Milestone
octopus
2 participants
@sebastian-philipp @liewegas