pacific kickoff #34272

liewegas · 2020-03-29T14:43:49Z

Add release definitions, release kickoff checklist, and other bits needed at the
start of each major release.

doc/dev/release-kickoff-checklist.rst

smithfarm · 2020-03-31T09:21:50Z

src/script/ceph-backport.sh

@@ -1082,7 +1082,7 @@ function try_known_milestones {
        mimic) mn="11" ;;
        nautilus) mn="12" ;;
        octopus) mn="13" ;;
-        pacific) mn="TBD" ;;
+        pacific) mn="14" ;;


we need to be careful with this one - the milestone number is set by GitHub. Pacific is expected to be milestone number 14, but we need to verify that before setting it here

Also, the script will work for pacific even when the number is set to "TBD" - it will fall back to querying the GitHub API to get the number.

ah, the "pacific" milestone has not been created yet, so we should not make this change now

it will be made when backporting to pacific starts.

smithfarm · 2020-03-31T09:38:29Z

doc/dev/release-checklists.rst

+Scripts
+~~~~~~~
+
+- [x] src/script/backport-create-issue (`releases()`)


we will modify backport-create-issue to support pacific only when backporting to pacific starts, so this item doesn't belong here

smithfarm · 2020-03-31T09:38:59Z

doc/dev/release-checklists.rst

+
+- [x] src/script/backport-create-issue (`releases()`)
+- [x] src/script/backport-resolve-issue (`releases()`, `ver_to_release()`... but for X-1)
+- [x] src/script/ceph-backport.sh (`try_known_milestones()`)


we will modify ceph-backport.sh to support pacific only when backporting to pacific starts, so this item doesn't belong here

smithfarm · 2020-03-31T09:39:58Z

src/script/backport-resolve-issue

@@ -350,7 +350,8 @@ def tag_sha1(repo, sha1):

 def ver_to_release():
    return {'v9.2': 'infernalis', 'v10.2': 'jewel', 'v11.2': 'kraken',
-            'v12.2': 'luminous', 'v13.2': 'mimic', 'v14.2': 'nautilus'}
+            'v12.2': 'luminous', 'v13.2': 'mimic', 'v14.2': 'nautilus',
+            'v15.2': 'octopus'}


smithfarm · 2020-03-31T09:40:05Z

src/script/backport-resolve-issue

@@ -324,7 +324,7 @@ def read_from_file(fs):
 def releases():
    return ('argonaut', 'bobtail', 'cuttlefish', 'dumpling', 'emperor',
            'firefly', 'giant', 'hammer', 'infernalis', 'jewel', 'kraken',
-            'luminous', 'mimic', 'nautilus')
+            'luminous', 'mimic', 'nautilus', 'octopus')


smithfarm · 2020-03-31T09:40:56Z

src/script/backport-create-issue

@@ -122,7 +122,7 @@ def connect_to_redmine(a):
 def releases():
    return ('argonaut', 'bobtail', 'cuttlefish', 'dumpling', 'emperor',
            'firefly', 'giant', 'hammer', 'infernalis', 'jewel', 'kraken',
-            'luminous', 'mimic', 'nautilus', 'octopus')
+            'luminous', 'mimic', 'nautilus', 'octopus', 'pacific')


smithfarm · 2020-03-31T10:24:35Z

doc/dev/release-checklists.rst

+- [x] src/script/backport-create-issue (`releases()`)
+- [x] src/script/backport-resolve-issue (`releases()`, `ver_to_release()`... but for X-1)
+- [x] src/script/ceph-backport.sh (`try_known_milestones()`)
+- [x] src/script/ceph-release-notes (X-1)


maybe also add https://github.com/ceph/ceph-build/blob/master/scripts/build_utils.sh release_from_version() ?

see also ceph/ceph-build#1540

liewegas · 2020-04-03T15:29:42Z

Doing a final check that the upgrades are working, but otherwise I think this is ready to go

src/include/ceph_features.h

liewegas · 2020-04-03T22:38:45Z

yep! fixed

neha-ojha · 2020-04-04T00:19:57Z

qa/suites/upgrade/nautilus-x/parallel/3-upgrade-sequence/upgrade-mon-osd-mds.yaml

@@ -20,7 +20,7 @@ upgrade-sequence:
   - sleep:
       duration: 60
   - ceph.restart:
-       daemons: [mon.c]
+       daemons: [mon.c, mgr.x]


We recently made this change in #33705 to fix https://tracker.ceph.com/issues/44387. I am afraid reverting it will make the bug reappear.

ah, ok. i'll just whitelist the message here too then. i was hoping to have one test that did the mons before mgr, but i think a manual test for this is sufficient.

cool, want to get rid of the qa/suites/upgrade/nautilus-x/parallel/3-upgrade-sequence/upgrade-mon-osd-mds.yaml change?

neha-ojha

LGTM, assuming #34272 (comment) is addressed.

Signed-off-by: Sage Weil <sage@redhat.com>

If our release isn't in the always_on_map, say because you just upgraded, then start with the modules from the last/most recent release. This should be sufficient to allow an upgrade when the mon is still the old release and the mgrmap doesn't tell us what modules we should be enabling. (Arguably, the always_on_modules should be enshrined in the MgrMap itself and not in the mon?) Signed-off-by: Sage Weil <sage@redhat.com>

Signed-off-by: Sage Weil <sage@redhat.com>

Fixes: https://tracker.ceph.com/issues/44883 Signed-off-by: Sage Weil <sage@redhat.com>

v2 was introduced in nautilus, and we don't support mimic -> pacific upgrades (only mimic -> octopus). This test can be removed! Signed-off-by: Sage Weil <sage@redhat.com>

This happens because mgrs may start before mons, or before mons have published a new mgrmap that disables orchestrator_cli. Signed-off-by: Sage Weil <sage@redhat.com>

Also rename 3-compat_client/mimic -> pacific to match the min_client setting (the naming here confuses me...). Signed-off-by: Sage Weil <sage@redhat.com>

Signed-off-by: Sage Weil <sage@redhat.com>

tchaikov · 2020-04-11T04:27:18Z

http://pulpito.ceph.com/kchai-2020-04-10_10:07:46-rados-wip-kefu-testing-2020-04-10-1430-distro-basic-smithi/

failures are not related.

tchaikov · 2020-04-11T04:45:56Z

@liewegas is this PR good to merge?

liewegas · 2020-04-11T13:22:46Z

@liewegas is this PR good to merge?

Almost, still sorting out why upgrade/nautilus-x is failing with

2020-04-10T21:46:37.686 INFO:teuthology.orchestra.run.smithi134.stdout:{"checks":{"MGR_MODULE_ERROR":{"severity":"HEALTH_ERR","summary":{"message":"Module 'orchestrator_cli' has failed: Not found or unloadable"}}},"status":"HEALTH_ERR"}

Old modules may be in the mgrmap (and always_on) but no longer exist. Do not try to load those or raise errors about them. Signed-off-by: Sage Weil <sage@redhat.com>

liewegas · 2020-04-12T22:35:04Z

finally merged!

clean upgrade run: http://pulpito.ceph.com/sage-2020-04-11_21:45:45-upgrade-wip-sage3-testing-2020-04-11-1337-distro-basic-smithi/

liewegas requested a review from a team as a code owner March 29, 2020 14:43

liewegas force-pushed the pacific-kickoff branch from 07c15a2 to b3d355c Compare March 29, 2020 14:44

tchaikov reviewed Mar 29, 2020

View reviewed changes

doc/dev/release-kickoff-checklist.rst Outdated Show resolved Hide resolved

liewegas added the wip-sage3-testing label Mar 30, 2020

smithfarm reviewed Mar 31, 2020

View reviewed changes

smithfarm suggested changes Mar 31, 2020

View reviewed changes

smithfarm reviewed Mar 31, 2020

View reviewed changes

liewegas force-pushed the pacific-kickoff branch 5 times, most recently from 317cf04 to 106bbc0 Compare April 1, 2020 22:55

This was referenced Apr 2, 2020

argparse: add positional=false option #33164

Closed

octopus: build/ops: fix ceph_release type to 'stable' #34194

Merged

liewegas requested review from smithfarm and neha-ojha April 3, 2020 15:29

smithfarm approved these changes Apr 3, 2020

View reviewed changes

neha-ojha reviewed Apr 3, 2020

View reviewed changes

src/include/ceph_features.h Show resolved Hide resolved

liewegas force-pushed the pacific-kickoff branch from 8263953 to 51baf81 Compare April 3, 2020 22:38

neha-ojha reviewed Apr 4, 2020

View reviewed changes

liewegas force-pushed the pacific-kickoff branch from 82e0a3f to 4263e4c Compare April 4, 2020 00:40

neha-ojha approved these changes Apr 4, 2020

View reviewed changes

liewegas force-pushed the pacific-kickoff branch from 4263e4c to 4db5dee Compare April 4, 2020 14:54

liewegas added 2 commits April 8, 2020 08:09

CMakeLists: 16.0.0

6d09963

Signed-off-by: Sage Weil <sage@redhat.com>

src/ceph_release: pacific, 16, dev

03e3703

Signed-off-by: Sage Weil <sage@redhat.com>

liewegas added 17 commits April 8, 2020 08:09

mds/cephfs_features: CEPHFS_CURRENT_RELEASE

6e7138d

Signed-off-by: Sage Weil <sage@redhat.com>

qa/releases/pacific.yaml

ac34ced

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/rados/thrash-old-clients/1-install/octopus

80fb39e

Signed-off-by: Sage Weil <sage@redhat.com>

doc/dev/release-kickoff-checklist: quotes

9322bae

Signed-off-by: Sage Weil <sage@redhat.com>

doc/dev/release-checklists: generalize

92fa0a6

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: define mgr modules for pacific

4803708

Signed-off-by: Sage Weil <sage@redhat.com>

qa/workunits/cephtool/test.sh: fix require-osd-release test

6833f89

Signed-off-by: Sage Weil <sage@redhat.com>

doc/dev/release-kickoff-checklist: include ceph-build change

3d8d2e0

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/rados/thrash-old-clients: adjust octopus package list for el7

858b3a9

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MonCommands: require-osd-release pacific

cc99c3b

Signed-off-by: Sage Weil <sage@redhat.com>

qa/standalone/mon/misc: update TEST_mon_features

279c437

Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/ugprade: remove mimic -> pacific upgrade tests

3c7d529

Signed-off-by: Sage Weil <sage@redhat.com>

mon/MgrMonitor: disable orchestrator_cli if >= octopus

e9ca9af

Fixes: https://tracker.ceph.com/issues/44883 Signed-off-by: Sage Weil <sage@redhat.com>

qa/standalone/mon/msgr-v2-transition: remove test

731e508

v2 was introduced in nautilus, and we don't support mimic -> pacific upgrades (only mimic -> octopus). This test can be removed! Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/upgrade: whitelist when orchestrator_cli can't be loaded

be5f525

This happens because mgrs may start before mons, or before mons have published a new mgrmap that disables orchestrator_cli. Signed-off-by: Sage Weil <sage@redhat.com>

qa/suites/fs/upgrade: s/mimic/nautilus/

985c203

Also rename 3-compat_client/mimic -> pacific to match the min_client setting (the naming here confuses me...). Signed-off-by: Sage Weil <sage@redhat.com>

liewegas force-pushed the pacific-kickoff branch from 919a61f to 985c203 Compare April 8, 2020 13:10

qa/suites/fs/upgrade: start with msgr2

8aa9c88

Signed-off-by: Sage Weil <sage@redhat.com>

tchaikov added the wip-kefu-testing label Apr 10, 2020

liewegas force-pushed the pacific-kickoff branch from 0886851 to 917618e Compare April 11, 2020 14:52

mgr/PyModuleRegistry: ignore 'obsolete' modules

a59f4e5

Old modules may be in the mgrmap (and always_on) but no longer exist. Do not try to load those or raise errors about them. Signed-off-by: Sage Weil <sage@redhat.com>

liewegas force-pushed the pacific-kickoff branch from 917618e to a59f4e5 Compare April 11, 2020 18:37

liewegas merged commit d3d1ea5 into ceph:master Apr 12, 2020

liewegas deleted the pacific-kickoff branch April 12, 2020 22:35

smithfarm mentioned this pull request Dec 3, 2020

octopus: qa: ignore evicted client warnings #38422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pacific kickoff #34272

pacific kickoff #34272

liewegas commented Mar 29, 2020

smithfarm Mar 31, 2020 •

edited

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020

smithfarm Mar 31, 2020 •

edited

liewegas commented Apr 3, 2020

liewegas commented Apr 3, 2020 via email

neha-ojha Apr 4, 2020

liewegas Apr 4, 2020

neha-ojha Apr 4, 2020

neha-ojha left a comment

tchaikov commented Apr 11, 2020

tchaikov commented Apr 11, 2020

liewegas commented Apr 11, 2020

liewegas commented Apr 12, 2020

pacific kickoff #34272

pacific kickoff #34272

Conversation

liewegas commented Mar 29, 2020

smithfarm Mar 31, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smithfarm Mar 31, 2020 • edited

Choose a reason for hiding this comment

liewegas commented Apr 3, 2020

liewegas commented Apr 3, 2020 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neha-ojha left a comment

Choose a reason for hiding this comment

tchaikov commented Apr 11, 2020

tchaikov commented Apr 11, 2020

liewegas commented Apr 11, 2020

liewegas commented Apr 12, 2020

smithfarm Mar 31, 2020 •

edited

smithfarm Mar 31, 2020 •

edited