Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Reduce size of component styles #34283

Merged
merged 1 commit into from Apr 2, 2020
Merged

mgr/dashboard: Reduce size of component styles #34283

merged 1 commit into from Apr 2, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Mar 30, 2020

Fixes: https://tracker.ceph.com/issues/44811

Signed-off-by: Tiago Melo tmelo@suse.com

Caugh by Angular 9 prod build:

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table-actions/table-actions.component.scss. Budget 6 kB was not met by 34.9 kB with a total of 40.9 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/info-card/info-card.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/health/health.component.scss. Budget 6 kB was not met by 180 kB with a total of 186 kB.

WARNING in Exceeded maximum budget for /ceph/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.scss. Budget 6 kB was not met by 188 kB with a total of 194 kB.

Before:
image

After:
image

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tspmelo tspmelo requested a review from a team as a code owner March 30, 2020 11:32
@tspmelo tspmelo changed the title mgr/dashboard: Reduce size of component styles mgr/dashboard: Reduce size of component styles Mar 31, 2020
@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 31, 2020

jenkins test dashboard

@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 31, 2020

jenkins test dashboard

@tspmelo tspmelo requested a review from a team March 31, 2020 15:04
@tspmelo
Copy link
Contributor Author

tspmelo commented Mar 31, 2020

jenkins test dashboard

@callithea callithea merged commit 9600b87 into ceph:master Apr 2, 2020
@tspmelo tspmelo deleted the wip-reduce-scss branch April 2, 2020 14:53
@epuertat epuertat mentioned this pull request Apr 7, 2020
Merged
3 tasks
@callithea callithea mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devp00l Devp00l Devp00l approved these changes

@callithea callithea callithea approved these changes

@epuertat epuertat epuertat approved these changes

Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
4 participants
@tspmelo @Devp00l @callithea @epuertat