Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: decrease pool stats if pg was removed #34289

Merged
merged 1 commit into from
Aug 10, 2020
Merged

mgr: decrease pool stats if pg was removed #34289

merged 1 commit into from
Aug 10, 2020

Conversation

agutikov
Copy link

@agutikov agutikov commented Mar 30, 2020 •
edited

After merge of placement groups resulting pg contains
objects from itself and merged one.
PGMap::apply_incremental treat this growth as pool stats delta,
but forget to decrease stats for removed pg.

Fixes: https://tracker.ceph.com/issues/44815
Signed-off-by: Aleksei Gutikov aleksey.gutikov@synesis.ru

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@agutikov
Copy link
Author

Steps to reproduce (nautilus):

# run cluster with vstart.sh
./bin/ceph osd pool create test 8 8
./bin/rados bench -p test 2 write --no-cleanup
# wait until stats synced
./bin/ceph df
./bin/ceph osd pool set default.rgw.buckets.data pg_num 4
# wait until pgs merged
./bin/ceph df

mgr: decrease pool stats if pg was removed
6090acd 
After merge of placement groups resulting pg contains
objects from itself and merged one.
PGMap::apply_incremental treat this growth as pool stats delta,
but forget to decrease stats for removed pg.

Fixes: https://tracker.ceph.com/issues/44815
Signed-off-by: Aleksei Gutikov <aleksey.gutikov@synesis.ru>
@stale
Copy link

stale bot commented Aug 3, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Aug 3, 2020
@neha-ojha neha-ojha removed the stale label Aug 6, 2020
jdurgin
jdurgin approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me, nice find!

@tchaikov
Copy link
Contributor

failure in upgrade test also exists in master

@tchaikov tchaikov merged commit ed0ca50 into ceph:master Aug 10, 2020
@agutikov agutikov deleted the pool_stats_pg_merge branch August 11, 2020 12:40
@smithfarm smithfarm mentioned this pull request Aug 15, 2020
Merged
@smithfarm smithfarm mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
core mgr needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
5 participants
@agutikov @tchaikov @jdurgin @gregsfortytwo @neha-ojha