doc/mgr/orchestrator: Add "Service Specification" #34290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-philipp
requested review from
jschmid1,
ricardoasmarques,
bk201 and
asettle
sebastian-philipp
force-pushed
the
doc-cephadm-service-spec
branch
from
ff1d220
to
2ce708f
Compare
|
jenkins test docs |
1 similar comment
|
jenkins test docs |
|
jenkins render docs |
|
Doc render available at http://docs.ceph.com/ceph-prs/34290/ |
asettle
requested changes
Mar 31, 2020
sebastian-philipp
force-pushed
the
doc-cephadm-service-spec
branch
from
f211a94
to
d8b58ce
Compare
jschmid1
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
2. Well, they are "DriveGroups", but users don't need to know it.
I think the less people have to memorize, the better. +1 for that change.
generally, thanks for taking care of the doc update. This was on my plate for such a long time now and I never got around going it :)
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
We already have a name for it: a Service Specification of type `osd`. We don't need to introduce a new name for it. Well, they are "DriveGroups", but users don't need to know it. Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
sebastian-philipp
force-pushed
the
doc-cephadm-service-spec
branch
from
d8b58ce
to
b740ae1
Compare
This was referenced Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
doc/cephadm/drivegroups: Update to new yaml
doc/cephadm/drivegroup: Don't introduce DriveGroups
We already have a name for it: a Service Specification of
type
osd. We don't need to introduce a new name for it.Well, they are "DriveGroups", but users don't need to know it.
Note: this is RFC and I'm happy to omit this commit
Fixes: https://tracker.ceph.com/issues/44716?issue_count=93&issue_position=5&next_issue_id=44739&prev_issue_id=44598
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox