rgw: pubsub sync module ignores ERR_USER_EXIST #34322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalif
approved these changes
Mar 31, 2020
cbodley
commented
Mar 31, 2020
src/rgw/rgw_sync_module_pubsub.cc
Outdated
| @@ -1055,7 +1055,7 @@ class RGWPSInitEnvCBCR : public RGWCoroutine { | |||
| create_user.display_name = "pubsub"; | |||
| create_user.generate_key = false; | |||
| yield call(new RGWUserCreateCR(sync_env->async_rados, sync_env->store, create_user, sync_env->dpp)); | |||
| if (retcode < 0) { | |||
| if (retcode < 0 && retcode != ERR_USER_EXIST) { | |||
There was a problem hiding this comment.
oops this needs to be -ERR_USER_EXIST
otherwise, this error gets returned by RGWPSDataSyncModule::start_sync() and data sync fails to start Fixes: https://tracker.ceph.com/issues/44857 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
passing the multisite suite http://pulpito.ceph.com/cbodley-2020-03-31_21:57:51-rgw:multisite-wip-cbodley-testing-distro-basic-smithi/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise, this error gets returned by RGWPSDataSyncModule::start_sync() and data sync fails to start
Fixes: https://tracker.ceph.com/issues/44857
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox