rgw/http: add timeout to http client #34414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalif
force-pushed
the
add_timeout_to_http_client
branch
from
f279cf2
to
5266b5f
Compare
cbodley
reviewed
Apr 6, 2020
There was a problem hiding this comment.
the POST stuff looks right 👍 there's also CURLOPT_POST, but sounds like that would make it harder to reuse the handle for later requests
|
jenkins, retest this please. |
also, prevent "Expect: 100-continue" from being sent when not needed Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
yuvalif
force-pushed
the
add_timeout_to_http_client
branch
from
5266b5f
to
dd49cc8
Compare
cbodley
approved these changes
Apr 7, 2020
|
except notifications the two places in RGW that use http client code are: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more http client related fixes:
donevalue was not checked. This is needed to fix "spurious wakeups"CURLOPT_INFILESIZEwas set with a pointer value and not the actual sizeFollowing Issues are not blockers for notification testing (e.g. #34293), and could be addressed later:
Expect: 100-continueto be sent. However, tests showed the the field is sent regardless. So, to prevent it it was removed explicitly from the header100 Continueresult code, the RGW treat that as an-EIOerror.If the server ignore that, there is no issueSigned-off-by: Yuval Lifshitz yuvalif@yahoo.com