Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: address some warnings raised by RPM 4.15.1 #34427

Merged
merged 2 commits into from Apr 8, 2020
Merged

spec: address some warnings raised by RPM 4.15.1 #34427

merged 2 commits into from Apr 8, 2020

Conversation

smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Apr 6, 2020 •
edited

RPM 4.15.1 warns:

  • It's not recommended to have unversioned Obsoletes.
  • extra tokens at the end of %endif directive

Heed the warnings.

Fixes: https://tracker.ceph.com/issues/44964

@smithfarm
ceph.spec.in: version an Obsoletes
48c79c1 
RPM 4.15.1 warns: It's not recommended to have unversioned Obsoletes.

Heed the warning.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
ceph.spec.in: remove extra tokens at end of %endif directive
853ff61 
RPM 4.15.1 warns: extra tokens at the end of %endif directive

Heed the warning.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
tchaikov
tchaikov reviewed Apr 7, 2020
View reviewed changes
ceph.spec.in Show resolved Hide resolved
@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2020

jenkins, retest this please.

smithfarm
smithfarm commented Apr 7, 2020
View reviewed changes
ceph.spec.in Show resolved Hide resolved
@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2020 

[ RUN      ] TestMockMirrorDisableRequest.Success
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/mutex_debug.h: In function 'ceph::mutex_debug_detail::mutex_debug_impl<<anonymous> >::~mutex_debug_impl() [with bool Recursive = false]' thread 7f012215f700 time 2020-04-07T06:12:06.400531+0000
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/mutex_debug.h: 109: FAILED ceph_assert(r == 0)
 ceph version Development (no_version) octopus (rc)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x19d) [0x7f013ade380f]
 2: (()+0x1599a91) [0x7f013ade3a91]
 3: (ceph::mutex_debug_detail::mutex_debug_impl<false>::~mutex_debug_impl()+0x31) [0x55691eed4a6b]
 4: (()+0x1e607fc) [0x55691f65f7fc]
 5: (()+0x1e63999) [0x55691f662999]
 6: (ContextWQ::process(Context*)+0xdd) [0x55691f086515]
 7: (ThreadPool::PointerWQ<Context>::_void_process(void*, ThreadPool::TPHandle&)+0x32) [0x55691f0eb048]
 8: (ThreadPool::worker(ThreadPool::WorkThread*)+0x730) [0x7f013ada34ec]
 9: (ThreadPool::WorkThread::entry()+0x32) [0x7f013ada747a]
 10: (Thread::entry_wrapper()+0x78) [0x7f013ad80c84]
 11: (Thread::_entry_func(void*)+0x18) [0x7f013ad80c02]
 12: (()+0x76db) [0x7f014474e6db]
 13: (clone()+0x3f) [0x7f01387b988f]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/run-rbd-unit-tests.sh: line 20: 22477 Aborted                 RBD_FEATURES=$i unittest_librbd

b-ranto
b-ranto approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@b-ranto b-ranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor

tchaikov commented Apr 7, 2020

jenkins test make check

@tchaikov
Copy link
Contributor

tchaikov commented Apr 8, 2020

https://shaman.ceph.com/builds/ceph/wip-kefu-testing-2020-04-07-2309/c085fd32876d89ed89d2a2b2fc5471fd12ab974c/

@tchaikov tchaikov merged commit b28a1da into ceph:master Apr 8, 2020
This was referenced Apr 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@b-ranto b-ranto b-ranto approved these changes

@tserong tserong Awaiting requested review from tserong

Assignees
No one assigned
Labels
build/ops needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@smithfarm @tchaikov @b-ranto