os/bluestore: fix huge (>4GB) bluefs reads #34503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ifed01 needs rebase |
ifed01
force-pushed
the
wip-ifed-fix-huge-bluefs-reads
branch
from
da52f60
to
7090ea0
Compare
|
@tchaikov - thanks, fixed. |
|
Ping @aclamk |
aclamk
approved these changes
Apr 28, 2020
| unique_ptr<char> huge_buf(new char[h->file->fnode.size]); | ||
| auto l = h->file->fnode.size; | ||
| int64_t r = fs.read(h, 0, l, NULL, huge_buf.get()); | ||
| ASSERT_EQ(r, l); | ||
| delete h; |
There was a problem hiding this comment.
Tip: it could be good to actually check h->file->fnode.size is as it should be.
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-fix-huge-bluefs-reads
branch
from
7090ea0
to
fe558c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes huge (>4GB) reads handling at BlueFS. Originally BlueFS reads returned 32-bit signed integer indicating amount of read data. Which got overflow for 4+GB lengths.
Partially fixes: https://tracker.ceph.com/issues/40300
Signed-off-by: Igor Fedotov ifedotov@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox