Fix memstore free space caculation #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally if memstore run out of space, it will report a very large positive number as free space. For example: root@bigmem:~# rados df pool name KB objects clones degraded unfound rd rd KB wr wr KB rbd 12366704 92240 0 0 0 0 0 92240 12366704 total used 12375877 92240 total avail 36028797009199167 total space 2611076 st->f_bavail = st->f_blocks - used_bytes / st->f_bsize This is due to used_bytes is an unsigned value, so compiler make the whole statement unsigned. Fix it by adding explicit type cast, st->f_bavail = long(st->f_blocks) - long(used_bytes / st->f_bsize) Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for fc13c1f is http://paste2.org/7wcsy7Kx |
Sent from
liewegas
added a commit
that referenced
this pull request
Jan 22, 2015
Fix memstore free space caculation Reviewed-by: Sage Weil <sage@redhat.com>
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally if memstore run out of space, it will report a very
large positive number as free space. For example:
root@bigmem:~# rados df
pool name KB objects clones degraded unfound rd rd KB wr wr KB
rbd 12366704 92240 0 0 0 0 0 92240 12366704
total used 12375877 92240
total avail 36028797009199167
total space 2611076
st->f_bavail = st->f_blocks - used_bytes / st->f_bsize
This is due to used_bytes is an unsigned value, so compiler make the whole statement unsigned.
Fix it by adding explicit type cast,
st->f_bavail = long(st->f_blocks) - long(used_bytes / st->f_bsize)
Signed-off-by: Xiaoxi Chen xiaoxi.chen@intel.com