mgr/test_orchestrator: fix error when listing services #34584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors when calling `from_json` of these classes: - InventoryHost: parsing labels - ServiceDescription: `last_refresh` and `created` fields should be parsed to datetime type. Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
|
sigh. |
|
@callithea I'd like to remove the test_orchestrator and instead run the dashboard as a workunit of rados/cephadm. test_orchestrator introduces a lot of mocking that is somehow alien to teuthology. Any idea how to accomplish this? |
- Adapting attribute change of ServiceSpec. - Update dummy data. Fixes: https://tracker.ceph.com/issues/45108 Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
sebastian-philipp
approved these changes
Apr 16, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/45108
Signed-off-by: Kiefer Chang kiefer.chang@suse.com
Orchestrator interface: Fixes errors when calling
from_jsonof these classes:last_refreshandcreatedfields should be parsedto datetime type.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox