Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/workunits:fix the error of getting encoding technique in ec test #34593

Merged
merged 1 commit into from May 22, 2020

Conversation

hfutljx
Copy link

@hfutljx hfutljx commented Apr 16, 2020

Isa / jerasure codec ‘technique’, obtained by the following statements,
"eval technique_parameter=$${plugin}2technique_${technique}",
which generate a string such as "isa2technique_vandermonde",
and assign the value of "technique_parameter" to "isa2technique_vandermonde".

String such as "isa2technique_vandermonde" should have a preset value, but it does not,
which will cause string "technique_parameter" to be empty.

Run the script, prompt the following error message and exit:
isa technique= is not a valid coding technique. Choose one of the following: reed_sol_van,cauchy

To fix the bug, specify a preset value for "technique_parameter":

  • isa2technique_vandermonde='reed_sol_van'
  • isa2technique_cauchy='cauchy'
  • jerasure2technique_vandermonde='reed_sol_van'
  • jerasure2technique_cauchy='cauchy_good'

Signed-off-by: lijiaxu lijiaxu@cmss.chinamobile.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

…technique in ec test

 Isa / jerasure codec ‘technique’, obtained by the following statements,
 "eval technique_parameter=\$${plugin}2technique_${technique}",
 which generate a string such as "isa2technique_vandermonde",
 and assign the value of "technique_parameter" to "isa2technique_vandermonde".

 String such as "isa2technique_vandermonde" should have a preset value, but it does not,
 which will cause string "technique_parameter" to be empty.

 Run the script, prompt the following error message and exit:
 isa technique= is not a valid coding technique.  Choose one of the following: reed_sol_van,cauchy

 To fix the bug, specify a preset value for "technique_parameter":

 + isa2technique_vandermonde='reed_sol_van'
 + isa2technique_cauchy='cauchy'
 + jerasure2technique_vandermonde='reed_sol_van'
 + jerasure2technique_cauchy='cauchy_good'

 Signed-off-by: lijiaxu <lijiaxu@cmss.chinamobile.com>
@hfutljx
Copy link
Author

hfutljx commented Apr 22, 2020

@tchaikov hi tchaikov,I submitted a pr to fix bug of qa/workunits/erasure-code/bench.sh, please review it, thx.

Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hfutljx hi Lijia, thanks for the excellent commit message, it explained the rationale why. will include this change in my next test batch.

@tchaikov tchaikov merged commit a9b6103 into ceph:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants