Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa/suites/*/rados_cls_all.yaml: load all classes #34605

Merged
merged 1 commit into from Apr 21, 2020
Merged

qa/suites/*/rados_cls_all.yaml: load all classes #34605

merged 1 commit into from Apr 21, 2020

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Apr 17, 2020 •
edited

the intention to add the whitelist was to test "sdk" class, but if we
add new classes to the list, and add tests exercising them, the tests
fail if we fail to update these rados_cls_all.yaml accordingly.

so in this change, the list is now '*' which allows OSD to load all
classes found in the specified directory

Fixes: https://tracker.ceph.com/issues/45113
Signed-off-by: Kefu Chai kchai@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov
Copy link
Contributor Author

http://pulpito.ceph.com/kchai-2020-04-20_01:56:10-rados:basic-master-distro-basic-smithi/

@tchaikov
qa/suites/*/rados_cls_all.yaml: load all classes
a2d1eae 
the intention to add the whitelist was to test "sdk" class, but if we
add new classes to the list, and add tests exercising them, the tests
fail if we fail to update these `rados_cls_all.yaml` accordingly.

so in this change, the list is now '*' which allows OSD to load all
classes found in the specified directory

Fixes: https://tracker.ceph.com/issues/45113
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov changed the title qa/suites/*/rados_cls_all.yaml: use default osd_class list qa/suites/*/rados_cls_all.yaml: load all classes Apr 20, 2020
@tchaikov tchaikov requested a review from neha-ojha April 20, 2020 10:59
@tchaikov
Copy link
Contributor Author

changelog

  • since we cannot change osd_class_load_list or osd_class_default_list at runtime, as an alternative, they are now changed to * to load all classes.

@neha-ojha could you please take another look?

@tchaikov
Copy link
Contributor Author

tchaikov commented Apr 20, 2020 •
edited

test passed at http://pulpito.ceph.com/kchai-2020-04-20_11:01:09-rados:basic-master-distro-basic-smithi/

neha-ojha
neha-ojha approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better!

@tchaikov tchaikov merged commit 713ef3c into ceph:master Apr 21, 2020
@tchaikov tchaikov deleted the wip-45113 branch April 21, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@cbodley cbodley Awaiting requested review from cbodley

Assignees
No one assigned
Labels
bug-fix needs-qa tests
Projects
None yet
Milestone
No milestone
2 participants
@tchaikov @neha-ojha