rgw: reshard: skip stale bucket id entries from reshard queue #34614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we encounter a reshard queue entry that has an older ID compared to the bucket's current ID, it'd mean that some other process or a manual reshard has already processed this entry, skip processing the entry this time. An alternative is to verify the num_shards that we have in queue >= the current shards, but this would mean that we may reshard a recently manual resharded bucket again which might not be intended Fixes: https://tracker.ceph.com/issues/45134 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
|
Manually tested on a vstart cluster, there aren't reshard tests currently in qa correct? |
cbodley
approved these changes
Apr 21, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we encounter a reshard queue entry that has an older ID compared to the
bucket's current ID, it'd mean that some other process or a manual reshard has
already processed this entry, skip processing the entry this time, as this could potentially mean we're processing a recently manually resharded entry again with a lower count. An
alternative is to verify the num_shards that we have in queue >= the current
shards, but this would mean that we may reshard a recently manual resharded
bucket again which might not be intended
Fixes: https://tracker.ceph.com/issues/45134
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox