New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/tasks/vstart_runner,doc: be compatible with python3 #34636
Conversation
as vstart_runner.py is compatible with python3, and so is the tests under `qa/` directory. and use `pip` to install teuthology, simpler this way. Signed-off-by: Kefu Chai <kchai@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally running run-backend-api-tests.sh: it works.
$ git clone https://github.com/ceph/teuthology | ||
$ cd teuthology/ | ||
$ virtualenv -p python2.7 ./venv | ||
$ virtualenv --python=python3 venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaikov For consistency, can you also update this line
https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/run-backend-api-tests.sh#L44
to sth like:
virtualenv --python=${TEUTHOLOGY_PYTHON_BIN:-/usr/bin/python3} venv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. updated and repushed.
jenkins render docs |
Run I have paste the fixing patch, could you fix it here ?
|
Doc render available at http://docs.ceph.com/ceph-prs/34636/ |
differentiate `str` and `bytes` instances, and drop python2 support from vstart_runner.py, as we've moved to python3 already Signed-off-by: Kefu Chai <kchai@redhat.com>
since vstart_runner.py is now py3, let's use python3 by default Signed-off-by: Kefu Chai <kchai@redhat.com>
745a04d
to
0cd4a2e
Compare
@lxbsz instead i am passing |
pass `StringIO()` to capture stdout whose value will be interpreted as a string later on Signed-off-by: Kefu Chai <kchai@redhat.com>
0cd4a2e
to
c5bd318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works for me.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox