Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/prometheus: ceph_pg_* metrics contains last value instead of sum across all reported states #34646

Closed
wants to merge 1 commit into from

Conversation

shyukri
Copy link
Contributor

@shyukri shyukri commented Apr 20, 2020

backport tracker: https://tracker.ceph.com/issues/44736


backport of #33967
parent tracker: https://tracker.ceph.com/issues/44590

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

During evaluation of pool stats metrics contains last reported value instead of sum

Fixes: https://tracker.ceph.com/issues/44590
Signed-off-by: Jacek Suchenia <jacek.suchenia@gmail.com>
(cherry picked from commit ad4d790)

 Conflicts:
	src/pybind/mgr/prometheus/module.py

Looks like whole function was new for mimic
@smithfarm smithfarm added this to the mimic milestone Apr 21, 2020
@smithfarm
Copy link
Contributor

 Conflicts:
	src/pybind/mgr/prometheus/module.py

Looks like whole function was new for mimic

This is an indication that the fix was marked for backport to mimic by mistake.

@smithfarm smithfarm closed this Apr 21, 2020
@shyukri shyukri deleted the wip-44736-mimic branch April 21, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants