Resharding tool for sharded rocksdb #34667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
reviewed
May 12, 2020
src/kv/RocksDBStore.cc
Outdated
| keys_per_iterator ++; | ||
|
|
||
| //check if need to write batch | ||
| if (bytes_in_batch > 1000000 || |
There was a problem hiding this comment.
should we make these dev options? could see potentially wanting to do it in larger batches for speed, or smaller to throttle things.
Created function that prepares environment for _open_db. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Reshard ability allows to change current sharding schema, without change to data. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Now merge operator name also includes operators from dedicated to shards. This makes it possible to reshard that will move prefix with merge operator away from default column family. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
…ing resharding Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
…ansferred Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Added possibility to control batch size and iterator refresh time for resharding process. Replaced getenv() with new control for resharding unittests. Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
aclamk
force-pushed
the
wip-rocksdb-reshard
branch
from
47beff3
to
38ac896
Compare
|
retest this please |
jdurgin
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces reshard() method to RocksDBStore.
It allows to change current sharding on existing database.
Gives ceph-bluestore-tool 'reshard' command that allows to apply that to BlueStore.