Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/orch: fix orch apply iscsi #34814

Merged
merged 3 commits into from May 5, 2020
Merged

mgr/orch: fix orch apply iscsi #34814

merged 3 commits into from May 5, 2020

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Apr 29, 2020 •
edited

Adds missing orch cli:
$ ceph orch apply iscsi --pool <pool>

Also fixes invocation error during apply:

Error ENOENT: ServiceSpec: __init__() missing 1 required positional argument: 'service_id

Fixes: https://tracker.ceph.com/issues/45249
Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mgfritch mgfritch requested a review from a team as a code owner April 29, 2020 00:28
@mgfritch mgfritch mentioned this pull request Apr 29, 2020
Closed
3 tasks
@bk201
Copy link
Contributor

bk201 commented Apr 29, 2020 •
edited

This PR or the mentioned PRs needs to be merged first for others to rebase.

@mgfritch
Copy link
Contributor Author

mgfritch commented Apr 30, 2020 •
edited

  • ceph orch apply -i <spec> works.
    👍

But, this mostly equivalent to the above? Do we want to support both variations (Related: #34843)?

$ ceph orch apply -i <spec>
--and--
$ ceph orch apply iscsi [pool] -i <spec>

Let's merge #34723 first and rebase the others.

sebastian-philipp and others added 3 commits May 4, 2020 12:23
@sebastian-philipp @mgfritch
mgr/cephadm: _apply_service: fix _create_iscsi invocation
53da12e 
Fixes: https://tracker.ceph.com/issues/45249
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@mgfritch
mgr/orch: add iscsi apply cli
884fc3d 
`$ ceph orch apply iscsi --pool <pool>`

Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
doc/mgr/orchestrator: update iscsi
586eb6c 
`apply iscsi` and `add iscsi` are implemented in cephadm

Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
Copy link
Contributor Author

mgfritch commented May 4, 2020

rebased and updated to remove the fqdn_enabled parameter #34723

@mgfritch
Copy link
Contributor Author

mgfritch commented May 5, 2020

http://pulpito.ceph.com/mgfritch-2020-05-05_02:07:06-rados-wip-mgfritch-testing-2020-05-04-1622-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor

http://pulpito.ceph.com/swagner-2020-05-04_13:28:01-rados-wip-swagner-testing-2020-05-04-1211-distro-basic-smithi/

https://tracker.ceph.com/issues/45335

@sebastian-philipp sebastian-philipp merged commit f6ef61c into ceph:master May 5, 2020
@ricardoasmarques ricardoasmarques mentioned this pull request May 5, 2020
Merged
4 tasks
@mgfritch mgfritch deleted the cephadm-iscsi-apply branch May 5, 2020 18:56
@mgfritch mgfritch mentioned this pull request May 5, 2020
Merged
3 tasks
@sebastian-philipp sebastian-philipp mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

Assignees
No one assigned
Labels
cephadm needs-qa orchestrator wip-mgfritch-testing wip-swagner-testing My Teuthology tests
Projects
None yet
Milestone
No milestone
3 participants
@mgfritch @bk201 @sebastian-philipp