Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa/tasks/cephadm.py: Support already bootstrapped clusters #34900

Merged
merged 2 commits into from May 18, 2020
Merged

qa/tasks/cephadm.py: Support already bootstrapped clusters #34900

merged 2 commits into from May 18, 2020

Conversation

gekios
Copy link
Contributor

@gekios gekios commented May 5, 2020

Add the possibility of being able to run cephadm.py on clusters that
were already bootstrapped by some other task/way so you can deploy the
rest of the daemons/services.

Signed-off-by: Georgios Kyratsas gkyratsas@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@gekios gekios requested a review from a team as a code owner May 5, 2020 07:43
@gekios gekios force-pushed the wip-cephadm-bootstrapped branch from f0f0ab4 to abcbbcd Compare May 5, 2020 10:51
@gekios gekios force-pushed the wip-cephadm-bootstrapped branch from abcbbcd to 7a0bc68 Compare May 5, 2020 10:55
@smithfarm smithfarm added the tests label May 6, 2020
@sebastian-philipp sebastian-philipp added the wip-swagner-testing My Teuthology tests label May 6, 2020
@sebastian-philipp
Copy link
Contributor 

Traceback (most recent call last):
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/run_tasks.py", line 90, in run_tasks
    manager.__enter__()
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-swagner-testing-2020-05-06-1716/qa/tasks/cephadm.py", line 1105, in task
    lambda: ceph_clients(ctx=ctx, config=config),
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/contextutil.py", line 56, in nested
    reraise(*exc)
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/virtualenv/lib/python3.6/site-packages/six.py", line 703, in reraise
    raise value
  File "/home/teuthworker/src/git.ceph.com_git_teuthology_master/teuthology/contextutil.py", line 29, in nested
    mgr = mgr_fn()
  File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-swagner-testing-2020-05-06-1716/qa/tasks/cephadm.py", line 1085, in <lambda>
    if not (ctx.ceph[cluster_name].bootstrapped) else _pass(),
KeyError: 'ceph'

http://pulpito.ceph.com/swagner-2020-05-07_08:46:28-rados-wip-swagner-testing-2020-05-06-1716-distro-basic-smithi/

@sebastian-philipp sebastian-philipp removed the wip-swagner-testing My Teuthology tests label May 7, 2020
@gekios gekios force-pushed the wip-cephadm-bootstrapped branch from 7a0bc68 to d5ab5fa Compare May 7, 2020 13:22
@gekios
Copy link
Contributor Author

gekios commented May 7, 2020

I had mistakenly put too much code in the function so I moved the namespace instantiation back in the task. Hopefully it should be fine now

@sebastian-philipp
Copy link
Contributor

http://pulpito.ceph.com:80/swagner-2020-05-08_09:28:04-rados-wip-swagner3-testing-2020-05-07-1813-distro-basic-smithi/

@gekios gekios force-pushed the wip-cephadm-bootstrapped branch from d5ab5fa to d4c89c9 Compare May 8, 2020 11:32
@gekios
Copy link
Contributor Author

gekios commented May 8, 2020

Oh I had missed this line cluster_name = config['cluster'] in the function... fyi it's public holiday here today so I will be back on Monday

@sebastian-philipp
Copy link
Contributor

fyi it's public holiday here today so I will be back on Monday

enjoy!

@gekios gekios mentioned this pull request May 11, 2020
Merged
@sebastian-philipp
Copy link
Contributor

http://pulpito.ceph.com/swagner-2020-05-11_17:31:17-rados-wip-swagner2-testing-2020-05-11-1650-distro-basic-smithi/

@gekios gekios force-pushed the wip-cephadm-bootstrapped branch 2 times, most recently from 451a664 to 62bbde4 Compare May 12, 2020 09:35
@sebastian-philipp
Copy link
Contributor

jenkins test make check

@sebastian-philipp
Copy link
Contributor

jenkins test make check

Georgios Kyratsas added 2 commits May 14, 2020 16:54
qa/tasks/cephadm.py: Support bootstrapped clusters
a002b28 
Add the possibility of being able to run cephadm.py on clusters that
were already bootstrapped by some other task/way so you can deploy the
rest of the daemons/services.

Signed-off-by: Georgios Kyratsas <gkyratsas@suse.com>
qa/tasks/cephadm: Add support for raw disks
35e1586 
Currently tests on raw disks are failing due to stripping '/dev/' from
device name. (ie https://tracker.ceph.com/issues/45383#change-165721)

Signed-off-by: Georgios Kyratsas <gkyratsas@suse.com>
@gekios
Copy link
Contributor Author

gekios commented May 14, 2020

I triggered a run and it looked good apart for 2 tests were seemingly running for like 7 hours and after checking most likely there was some malfunction since they weren't locked. http://pulpito.ceph.com/gkyratsas-2020-05-14_15:43:26-rados:cephadm-wip-gkyratsas-testing-34900-distro-basic-smithi/

@gekios
Copy link
Contributor Author

gekios commented May 18, 2020

I investigated a bit and found that the test that's failing to me seems broken in general for ubuntu_latest. http://pulpito.ceph.com/gkyratsas-2020-05-15_14:21:35-rados:cephadm-wip-gkyratsas-testing-34900-distro-basic-smithi/ is my run compared with the last run I found on top of master branch http://pulpito.ceph.com/nojha-2020-05-12_16:52:34-rados:cephadm-master-distro-basic-smithi/

@gekios
Copy link
Contributor Author

gekios commented May 18, 2020

I have triggered a test on top of master filtering out ubuntu_latest and it was successful. http://pulpito.ceph.com/gkyratsas-2020-05-18_10:48:02-rados:cephadm-master-distro-basic-smithi/

@sebastian-philipp sebastian-philipp merged commit 71c7f95 into ceph:master May 18, 2020
@gekios gekios deleted the wip-cephadm-bootstrapped branch May 19, 2020 10:12
@sebastian-philipp sebastian-philipp mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

Assignees
No one assigned
Labels
cephadm tests
Projects
None yet
Milestone
No milestone
3 participants
@gekios @sebastian-philipp @smithfarm