librados: handle failed watch registration better #3494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If watch() failed, the LingerOp would be deleted, but a pointer to it would live on in the handle passed by the caller. An unwatch() called on that handle would cause a segfault. Set handle only after the watch osd op has returned, and set it to 0 on failure. Make unwatch() return 0 early if passed a handle of 0, to get back the earlier behavior of not segfaulting if a non-registered cookie is passed to unwatch(). This aspect of the interface changed when the new watch2/notify2 functions were introduced. Fixes #10644 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
The bug this was working around was fixed a while ago. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for b1146ec is http://paste2.org/_wDmzbb9s |
Sent from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If watch() failed, the LingerOp would be deleted, but a pointer to it
would live on in the handle passed by the caller. An unwatch() called
on that handle would cause a segfault.
Set handle only after the watch osd op has returned, and set it to 0
on failure. Make unwatch() return 0 early if passed a handle of 0, to
get back the earlier behavior of not segfaulting if a non-registered
cookie is passed to unwatch(). This aspect of the interface changed
when the new watch2/notify2 functions were introduced.