rgw/notifications: version id was not sent in versioned buckets #34958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com> Fixes: https://tracker.ceph.com/issues/45440
mattbenjamin
reviewed
May 8, 2020
| @@ -4180,7 +4180,7 @@ void RGWPutObj::execute() | |||
| } | |||
|
|
|||
| // send request to notification manager | |||
| const auto ret = rgw::notify::publish(s, s->object, s->obj_size, mtime, etag, rgw::notify::ObjectCreatedPut, store); | |||
| const auto ret = rgw::notify::publish(s, obj.key, s->obj_size, mtime, etag, rgw::notify::ObjectCreatedPut, store); | |||
There was a problem hiding this comment.
for review purposes, how is obj.key improved over s->object?
There was a problem hiding this comment.
for review purposes, how is obj.key improved over s->object?
s->object contains the object key from the request. in case of "put" it does not contain the version (only "delete" has version in the request).
obj.key contains the version in case of a versioned bucket
|
teuthology run: http://pulpito.front.sepia.ceph.com/yuvalif-2020-05-08_12:06:07-rgw:multisite-fix_versioning_in_notif-distro-basic-smithi/ |
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuval Lifshitz ylifshit@redhat.com
Fixes: https://tracker.ceph.com/issues/45440