vstart_runner.py: use tuple instead of set #34962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rishabh-d-dave
force-pushed
the
fs-qa-py3-use-tuple
branch
from
a3f6cad
to
bc1fcbd
Compare
Using python3 leads to an error that says "TypeError: unhashable type: 'Raw'". Fixes: https://tracker.ceph.com/issues/45446 Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
force-pushed
the
fs-qa-py3-use-tuple
branch
from
bc1fcbd
to
cb0bfc8
Compare
sidharthanup
approved these changes
May 11, 2020
There was a problem hiding this comment.
LGTM 👍 . After this patch and 8823060, vstart_runner runs without errors.
batrick
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using python3 leads to an error that says
"TypeError: unhashable type: 'Raw'".
Fixes: https://tracker.ceph.com/issues/45446
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox