cephadm: enable logging to stderr in ceph-iscsi #35013
Conversation
|
needs rebase to fix |
All the other ceph servies when deployed are deployed with: --default-log-to-stderr=true --default-log-stderr-prefix=debug --default-log-to-file=false Ceph-iscsi doesn't have these as commandline params but once ceph/ceph-iscsi#186 lands it'll have something similar as config options. This patch sets these options Signed-off-by: Matthew Oliver <moliver@suse.com>
matthewoliver
force-pushed
the
cephadm-iscsi-log-to-stderr
branch
from
8c2a7b9
to
f655846
Compare
|
@ricardoasmarques is ceph-iscsi version released for sure before the next octopus patch release (15.2.3) ? |
|
In any case I'm a bit concerned that we release a ceph version depending on a ceph-iscsi version which is not yet released. Is this a valid concern? |
If an old version of iscsi was used with this PR, would the new config options simply be ignored (e.g. continue logging to a file instead of stderr/journald)? Or would the iscsi daemon complain about the new options? |
|
Yeah, the config options would just be ignored on and old version. I can test if required, but that's what the code says. |
All the other ceph servies when deployed are deployed with:
--default-log-to-stderr=true --default-log-stderr-prefix=debug
--default-log-to-file=false
Ceph-iscsi doesn't have these as commandline params but once
ceph/ceph-iscsi#186 lands it'll have something
similar as config options. This patch sets these options
Signed-off-by: Matthew Oliver moliver@suse.com
Fixes: https://tracker.ceph.com/issues/45245
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox