librados: rectify the pool name caching in IoCtxImpl. #3507
Conversation
Fixes: #10458 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
| @@ -1019,8 +1019,6 @@ namespace librados | |||
| void set_assert_version(uint64_t ver); | |||
| void set_assert_src_version(const std::string& o, uint64_t ver); | |||
|
|
|||
| const std::string& get_pool_name() const; | |||
|
|
|||
There was a problem hiding this comment.
I think changing the signature for this function is problematic if we want to avoid breaking linkage.
We could keep an internal string list of all unique names we've seen for the pool and return const refs to those. pretty lame but ...
There was a problem hiding this comment.
Yeah, this is annoying... I guess we need to keep the member var after all, just for return values for this version
There was a problem hiding this comment.
I was afraid about linking problems too, so added the const modifier to std::string get_pool_name() -- please refer line 626. C++ does not respect the returned type during method overloading, I suppose.
There was a problem hiding this comment.
we can't add const to the other version either, as that's also an ABI change
|
@jdurgin ? |
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 1833627 is http://paste2.org/_7cXn0LCG |
Sent from 
| ls.push_back(io_ctx_impl->pool_name); | ||
| std::string pool_name; | ||
|
|
||
| io_ctx_impl->client->pool_get_name(io_ctx_impl->get_id(), &pool_name); |
There was a problem hiding this comment.
should check return value of this - the pool could have been deleted
Fixes: #10458 Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com