rbd-mirror: stop local journal replayer first during shut down #35348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillaman Don't you think it will re-introduce [1]? The reason why the order was changed was that the replay shut down could be initiated when a replay flush was in progress (which also does the shut down). |
|
Forgot about that. We need to keep this order but I suppose that just means we need additional tracking for flushes added. |
added 2 commits
June 3, 2020 07:50
…l replay" This reverts commit aeccb03. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If a journal replay flush is in-progress when the ImageReplayer is stopped, it can race and result in an assertion failure due to two attempted shutdowns of the same journal replay state machine. Fixes: https://tracker.ceph.com/issues/45409 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Tweaked |
trociny
reviewed
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutting down the local journal replayer will flush any IO and cancel any
potentially stuck ops (waiting for FinishOp event). This reverts back to the
pre-Octopus behavior prior to the refactoring to support snapshot mirroring.
Fixes: https://tracker.ceph.com/issues/45714
Signed-off-by: Jason Dillaman dillaman@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox