osdc: Fix crash on OSD failure #35422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSDSession::lock should not use lockdep, as we violate its rules in a place that's safe. Revert it to std::mutex. Thanks to Or Friedmann <ofriedma@redhat.com> for finding the problem. Fixes: https://tracker.ceph.com/issues/45878 Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
cbodley
approved these changes
Jun 5, 2020
|
@adamemerson if we're planning to backport all of your Objecter changes to octopus, we'll need to track fixes like this for backport as well |
|
Good point. What's our usual way for doing that? |
|
there should be a tracker issue for the initial Objecter backport. until that backport merges, we can add comments there with any additional PRs to include |
tchaikov
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSDSession::lock should not use lockdep, as we violate its rules in a
place that's safe. Revert it to std::mutex.
Thanks to Or Friedmann ofriedma@redhat.com for finding the problem.
Fixes: https://tracker.ceph.com/issues/45878