Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/k8sevents: sanitise kubernetes events #35563

Merged
merged 1 commit into from Jul 16, 2020
Merged

nautilus: mgr/k8sevents: sanitise kubernetes events #35563

merged 1 commit into from Jul 16, 2020

Conversation

pcuzner
Copy link
Contributor

@pcuzner pcuzner commented Jun 15, 2020

backport tracker: https://tracker.ceph.com/issues/46122
possibly a backport of #35010
parent tracker: https://tracker.ceph.com/issues/45972


original PR body:
Kubernetes can generate events without a timestamp
or an event count. When this occurs the k8sevents 'ls'
command fails due to None type values. This patch
sanitises the event received before adding to the
internal data structures to account for these
issues.

Signed-off-by: Paul Cuzner pcuzner@redhat.com
(cherry picked from commit 48d1781)


updated using ceph-backport.sh version 15.1.1.389

Kubernetes can generate events without a timestamp
or an event count. When this occurs the k8sevents 'ls'
command fails due to None type values. This patch
sanitises the event received before adding to the
internal data structures to account for these
issues.

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
(cherry picked from commit 48d1781)
@pcuzner pcuzner added this to the nautilus milestone Jun 15, 2020
@pcuzner pcuzner requested a review from b-ranto June 15, 2020 02:52
@b-ranto b-ranto added the nautilus-batch-1 nautilus point releases label Jun 16, 2020
@b-ranto b-ranto changed the title mgr/k8sevents:sanitise kubernetes events [nautilus] mgr/k8sevents:sanitise kubernetes events Jun 16, 2020
@smithfarm smithfarm changed the title [nautilus] mgr/k8sevents:sanitise kubernetes events nautilus: mgr/k8sevents: sanitise kubernetes events Jun 20, 2020
@smithfarm smithfarm added orchestrator core and removed nautilus-batch-1 nautilus point releases labels Jun 20, 2020
@smithfarm smithfarm removed the core label Jun 20, 2020
@yuriw
Copy link
Contributor

yuriw commented Jul 1, 2020

@yuriw
Copy link
Contributor

yuriw commented Jul 8, 2020

@pcuzner pcuzner merged commit a411eae into ceph:nautilus Jul 16, 2020
@pcuzner pcuzner deleted the wip-45972-nautilus branch July 16, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants