qa/tasks: make sh() in vstart_runner.py identical with teuthology.orchestra.remote.sh #35639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
reviewed
Jun 18, 2020
qa/tasks/vstart_runner.py
Outdated
| @@ -422,7 +422,7 @@ def _do_run(self, args, check_status=True, wait=True, stdout=None, | |||
|
|
|||
| return proc | |||
|
|
|||
| # XXX: for compatibility keep this method same teuthology.orchestra.remote.sh | |||
| # XXX: for compatibility keep this method same as in teuthology.orchestra.remote.py | |||
There was a problem hiding this comment.
This is incorrect, you use either teuthology.orchestra.remote.sh or teuthology/orchestra/remote.py, but in the latter case you need to put reference to teuthology repo since you are in ceph repo.
There was a problem hiding this comment.
oops, I just misinterpreted .sh as file extension. Fixed.
joscollin
force-pushed
the
wip-fix-sh-as-in-teuthology
branch
2 times, most recently
from
ce166a9
to
a53fa39
Compare
…hestra.remote.sh Fixes: https://tracker.ceph.com/issues/46069 Signed-off-by: Jos Collin <jcollin@redhat.com>
joscollin
force-pushed
the
wip-fix-sh-as-in-teuthology
branch
from
a53fa39
to
63a9ddc
Compare
rishabh-d-dave
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Tested the PR -
2020-07-01 17:53:30,179.179 INFO:__main__:Stopped test: test_issue_cephfs_shell_cmd_at_invocation (tasks.cephfs.test_cephfs_shell.TestMisc) in 16.592094s
2020-07-01 17:53:30,179.179 INFO:__main__:
2020-07-01 17:53:30,179.179 INFO:__main__:----------------------------------------------------------------------
2020-07-01 17:53:30,179.179 INFO:__main__:Ran 1 test in 16.592s
2020-07-01 17:53:30,179.179 INFO:__main__:
2020-07-01 17:53:30,180.180 INFO:__main__:OK
From test_issue_cephfs_shell_cmd_at_invocation -
class TestMisc(TestCephFSShell):
def test_issue_cephfs_shell_cmd_at_invocation(self):
"""
Test that `cephfs-shell -c conf cmd` works.
"""
# choosing a long name since short ones have a higher probability
# of getting matched by coincidence.
dirname = 'somedirectory'
self.run_cephfs_shell_cmd(['mkdir', dirname])
output = self.mount_a.client_remote.sh(['cephfs-shell', 'ls']).\
strip()
|
Jenkins retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/46069