mds: multiple mds scrub support #35749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ukernel
force-pushed
the
simon_work_scrub
branch
from
e3e0410
to
96606b7
Compare
ukernel
force-pushed
the
simon_work_scrub
branch
10 times, most recently
from
6648144
to
73f24d7
Compare
sidharthanup
reviewed
Jul 3, 2020
sidharthanup
reviewed
Jul 6, 2020
ukernel
force-pushed
the
simon_work_scrub
branch
3 times, most recently
from
9747945
to
02701f9
Compare
|
jenkins test dashboard backend |
ukernel
force-pushed
the
simon_work_scrub
branch
from
02701f9
to
a29a0c1
Compare
|
jenkins retest this please |
ukernel
force-pushed
the
simon_work_scrub
branch
from
a29a0c1
to
9caf8d2
Compare
ukernel
force-pushed
the
simon_work_scrub
branch
from
9caf8d2
to
a604d03
Compare
sidharthanup
suggested changes
Aug 20, 2020
ukernel
force-pushed
the
simon_work_scrub
branch
from
a604d03
to
5f1d3a3
Compare
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Nov 7, 2020
* refs/pull/35749/head:
qa/cephfs: Add more tests for multimds scrub
qa/cephfs: add tests for multimds scrub
qa/cephfs: update existing scrub test cases
mds: don't skip validating disk state of symlink
mds: abort/pause/resume scrubs in multiple mds
mds: track scrub status in multiple mds
mds: remove on_finish from {CInode,CDir}::scrub_info_t
Continuation: don't delete self while there are in-processing stages
mds: auth pin CInode when validating its disk state
mds: rdlock file/nest lock when accumulating stats of subtree dirfrags
mds: multiple mds scrub support
include/frag: add encode/decode functions for fragset_t
mds: remove object can't be scrubbed immediately from scrub stack
mds: prevent dirfrag scrub/fragment from running at the same time
mds: change scrub traverse from post-order to breadth-first search
mds: make both CInode and CDir as entities of scrub
mds: remove ScrubStack::scrubstack
batrick
requested changes
Nov 8, 2020
batrick
requested changes
Nov 10, 2020
There was a problem hiding this comment.
Should cite this tracker: https://tracker.ceph.com/issues/12274
ukernel
force-pushed
the
simon_work_scrub
branch
from
b088aff
to
41786a4
Compare
|
just add "Fixes: https://tracker.ceph.com/issues/12274" to commit "mds: multiple mds scrub support". no other change |
|
@ukernel still need log ignorelist change for: #35749 (review) |
comment says it's hack for dout. I don't see any reason it's needed. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Making CDir as entity of scrub is preparetion for scrubbing across multiple mds. When subtree bound is encountered, scrub should be forwarded to subtree's auth mds. The auth mds adds CDir to scrub stack. Signed-off-by: Simon Gao <simon29rock@gmail.com> Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
After using breadth-first search, scrubing a dir inode does not need to wait until all of its descendant difrags/inodes are scrubbed. This simplfies scrub code a lot. The downside is that a scrubbed dir inode no longer implies corresponding subtree has been fully scrubbed. It makes later scrub (without force option) less efficient. Signed-off-by: Simon Gao <simon29rock@gmail.com> Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
When a CDir is in scrub stack, mds should not split/merge it. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
This avoid checking objects that can't be scrubbed repeatly. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
If a non-auth object is encountered during scrubbing, forward scrub to the object's auth mds. Fixes: https://tracker.ceph.com/issues/12274 Signed-off-by: Simon Gao <simon29rock@gmail.com> Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Simon Gao <simon29rock@gmail.com> Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
A CInode/CDir is scrubbed no longer means corresponding subtree is fully
scrubbed. The on_finish in {CInode,CDir}::scrub_info_t become useless.
This patch also removes code that flushs journal if scrub has repaired
anything. Later patch will add the code back at different place.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Scrubs are always initialized from mds.0. So mds.0 can ensure that scrub tags are unique globally. mds.0 periodically gathers scrubs running in itself and in other mds. A scrub is finished only if it's not running in any mds. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Limit scrub abort/pause/resume commands to mds.0. mds.0 sends messages to other mds, asks them to abort/pause/resume scrubs. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
we can check if backtrace is valid and check if inode number is in-use Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Now scrub is always async. Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
ukernel
force-pushed
the
simon_work_scrub
branch
from
41786a4
to
c42570a
Compare
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
|
https://pulpito.ceph.com/?branch=wip-pdonnell-testing-20201116.174825 First round of errors were transient. |
batrick
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/12274
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox