rbd: watch command should unwatch before exiting #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched the rbd CLI tool to use the new watch/unwatch API and properly unwatch the image before exiting. Additionally, the watch command opened the image twice -- once R/W and another R/O. This resulted in two watches being created for the image. Cleaned up old/new format detection by using the existing API methods. Fixes: #10709 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Feb 2, 2015
rbd: watch command should unwatch before exiting Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for c9ab559 is http://paste2.org/_vCAffUN9 |
Sent from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watch CLI command did not properly unwatch the image before exiting. It also opened the image as R/W which resulted in two watches being established on the image.