mgr/dashboard: Display cluster status in favicon #36000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test dashboard |
|
jenkins test dashboard backend |
epuertat
reviewed
Jul 10, 2020
Comment on lines
53
to
63
| let color = 'transparent'; | ||
| switch (status) { | ||
| case 'HEALTH_OK': | ||
| color = '#00bb00'; | ||
| break; | ||
| case 'HEALTH_WARN': | ||
| color = '#ffa500'; | ||
| break; | ||
| case 'HEALTH_ERR': | ||
| color = '#ff0000'; | ||
| break; |
There was a problem hiding this comment.
Can colors be extracted to a constants file, just no to have the same colors repeated (e.g.: HealthPipe, ...)?
There was a problem hiding this comment.
sure, I can do that.
|
@epuertat I also found some package that did it, not sure if it was that one. |
s0nea
approved these changes
Jul 15, 2020
|
jenkins test dashboard |
|
jenkins test dashboard backend |
votdev
requested changes
Jul 16, 2020
src/pybind/mgr/dashboard/frontend/src/app/shared/services/favicon.service.ts
Outdated
Show resolved
Hide resolved
Fixes: https://tracker.ceph.com/issues/44542 Signed-off-by: Tiago Melo <tmelo@suse.com>
votdev
approved these changes
Jul 16, 2020
|
jenkins test dashboard backend |
votdev
added a commit
to votdev/ceph
that referenced
this pull request
Jul 17, 2020
Use radius of 2px like on GitHub to increase visibility of the status circle. Follow up of PR ceph#36000. Signed-off-by: Volker Theile <vtheile@suse.com>
3 tasks
ideepika
pushed a commit
to ideepika/ceph
that referenced
this pull request
Aug 7, 2020
Use radius of 2px like on GitHub to increase visibility of the status circle. Follow up of PR ceph#36000. Signed-off-by: Volker Theile <vtheile@suse.com>
|
Did someone test this on Firefox? It does not work for me: https://tracker.ceph.com/issues/46918 |
ideepika
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Sep 3, 2020
Use radius of 2px like on GitHub to increase visibility of the status circle. Follow up of PR ceph/ceph#36000. Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/44542
Signed-off-by: Tiago Melo tmelo@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox