install-deps.sh: get lsb_release if needed #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
thanks for improving Fedora-based distro support 👍 |
Fedora does not have lsb_release installed by default. http://tracker.ceph.com/issues/10729 Fixes: #10729 Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 3, 2015
install-deps.sh: get lsb_release if needed Reviewed-by: Haïkel Guémar <hguemar@redhat.com>
ghost
merged commit 
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 01a4aa8 is http://paste2.org/_PvOAH8nx |
Sent from
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora does not have lsb_release by default. Since all supported Debian
based distributions already have it, assume yum is the way to install it
http://tracker.ceph.com/issues/10729 Fixes: #10729
Signed-off-by: Loic Dachary ldachary@redhat.com