rgwlc: fix error return from backward-compat decode #36246
Conversation
Exception handling in backward-compat case returned EIO even when the actual backward-compat decode succeeded. Fixes: https://tracker.ceph.com/issues/46677 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
force-pushed
the
wip-rgwlc-decode
branch
from
91b3d3b
to
fa30361
Compare
| @@ -3775,13 +3775,14 @@ static int rgw_cls_lc_list_entries(cls_method_context_t hctx, bufferlist *in, | |||
| /* try backward compat */ | |||
| pair<string, int> oe; | |||
| try { | |||
| iter = it->second.begin(); | |||
There was a problem hiding this comment.
Probably doesn't matter, but the initial set above is a const iter (cbegin(), not begin())
There was a problem hiding this comment.
since it doesn't affect compilation (you can assign a non-const iterator to a const_iterator), lets just get this tested and merged
|
jenkins test make check |
|
@cbodley @epuertat @alfonsomthd I don't see any connection between this PR and ceph dashboard backend API tests; blocking a PR from merging is a high bar--it seems like something isn't working as expected |
|
jenkins test dashboard backend |
@mattbenjamin I re-triggered the job with Also, the last CEPH API Nightly job was also successful: Regarding the not apparent connection, this job is a safeguard (for Ceph project API) in the same way We are aware that the API job have been sometimes unstable so @epuertat and @tchaikov have recently made improvements. |
Exception handling in backward-compat case returned EIO even when
the actual backward-compat decode succeeded.
Fixes: https://tracker.ceph.com/issues/46677
Signed-off-by: Matt Benjamin mbenjamin@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox