nautilus: librbd: new "write_zeroes" API methods to supplement the "discard" APIs #36250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2020 15:14
Unlike the existing 'discard' option which is more of a hint to attempt to release space, the new 'write_zeroes' APIs will ensure that the entire provided extent is fully zeroed. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit ae6dd86) Conflicts: src/librbd/api/Io.h/cc: logic exists in ImageRequestWQ files src/librbd/librbd.cc: trivial resolution due missing api::Io src/test/librbd/test_librbd.cc: trivial resolution (cherry picked from commit 0e3add9) Conflicts: src/librbd/io/ImageRequestWQ.cc: different locks and no overlap guard src/test/librbd/test_librbd.cc: trivial resolution
Fixes: https://tracker.ceph.com/issues/45986 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit f319ecf) (cherry picked from commit f53e43c)
Yup and yup. I’ve always found it easier to not start over with a cherry-pick and instead base it on the previous release’s effort. |
smithfarm
changed the title
discard APIs
smithfarm
changed the title
|
Oops. Nautilus PR got merged before the Octopus one from which it was cherry-picked :-( Next time I'll try to remember to add DNM. I also tend to cherry-pick from the newer stable branch if it makes the conflict resolution easier. |
|
So, apparently this broke the i386 build? See #36620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/46673