Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: ceph-volume: report correct rejected reason in inventory if device type is invalid #36453

Merged
merged 2 commits into from Sep 15, 2020
Merged

nautilus: ceph-volume: report correct rejected reason in inventory if device type is invalid #36453

merged 2 commits into from Sep 15, 2020

Commits on Sep 10, 2020

  1. ceph-volume: cleanup code 

    Simplify the logic and fix a typo.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 0169b72)
    @satoru-takeuchi
    satoru-takeuchi authored and Jan Fajerski committed Sep 10, 2020
    Copy the full SHA
    85f0260 View commit details
    Browse the repository at this point in the history

  2. ceph-volume: show correct rejected reason in inventory if device type… 

    … is not acceptable

If device type is not acceptable in `c-v inventory`, its rejected reason
becomes "Insufficient space (<5GB)" by mistake. It's because sys_api is
empty due to skipping devices that are neither `disk` nor `device`. We
should report the target device is not acceptable in this case.

Fixes: https://tracker.ceph.com/issues/46102

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
(cherry picked from commit 3e5d91d)
    @satoru-takeuchi
    satoru-takeuchi authored and Jan Fajerski committed Sep 10, 2020
    Copy the full SHA
    210ad89 View commit details
    Browse the repository at this point in the history