Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Datatable catches select events from other datatables #36590

Merged
merged 1 commit into from Aug 27, 2020
Merged

mgr/dashboard: Datatable catches select events from other datatables #36590

merged 1 commit into from Aug 27, 2020

Conversation

votdev
Copy link
Member

@votdev votdev commented Aug 12, 2020

Ensure we do not process DOM 'select' events, see swimlane/ngx-datatable#899.

Fixes: https://tracker.ceph.com/issues/46903

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@votdev
mgr/dashboard: Datatable catches select events from other datatables
31e9bbb 
Ensure we do not process DOM 'select' events, see swimlane/ngx-datatable#899.

Fixes: https://tracker.ceph.com/issues/46903
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev requested a review from a team as a code owner August 12, 2020 14:27
@votdev
Copy link
Member Author

votdev commented Aug 13, 2020

jenkins retest this please

@votdev votdev added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Aug 13, 2020
@votdev
Copy link
Member Author

votdev commented Aug 13, 2020

jenkins retest this please

@votdev
Copy link
Member Author

votdev commented Aug 13, 2020

jenkins test dashboard

1 similar comment
@votdev
Copy link
Member Author

votdev commented Aug 14, 2020

jenkins test dashboard

@votdev votdev requested a review from a team August 14, 2020 06:39
@votdev
Copy link
Member Author

votdev commented Aug 14, 2020

jenkins test dashboard

@LenzGr LenzGr merged commit 6040a45 into ceph:master Aug 27, 2020
@votdev votdev deleted the issue_46903_prevent_select_events branch August 27, 2020 11:01
@callithea callithea mentioned this pull request Aug 31, 2020
Merged
@tspmelo tspmelo mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspmelo tspmelo tspmelo approved these changes

@callithea callithea callithea approved these changes

Assignees
No one assigned
Labels
bug-fix dashboard skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
None yet
Milestone
No milestone
4 participants
@votdev @tspmelo @callithea @LenzGr