PGLog::rewind_divergent_log must not call mark_dirty_from on end() #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGLog::rewind_divergent_log is dereferencing iterator "p" though it is already past the end of its container. When entering the loop for the first time, p is log.log.end() and must not be dereferenced. mark_dirty_from must only be called after p--. It will not rewind past begin() because of the if (p == log.log.begin()) test above. http://tracker.ceph.com/issues/5398 fixes #5398 Signed-off-by: Loic Dachary <loic@dachary.org>
athanatos
added a commit
that referenced
this pull request
Jun 19, 2013
PGLog::rewind_divergent_log must not call mark_dirty_from on end() Reviewed-by: Samuel Just <sam.just@inktank.com>
andriytk
pushed a commit
to andriytk/cortx-rgw
that referenced
this pull request
Aug 31, 2022
…Tagging API. (ceph#366) Problem: Observed discrepancy with AWS for DeleteBucketTagging API. In ceph-RADOS DeleteBucketTagging API returning status code=200 on success, while in AWS it is returning status code=204. Solution: Assign op_ret=STATUS_NO_CONTENT when DeleteBucketTagging operation is successful. Signed-off-by: Shriya Deshmukh <shriya.deshmukh@seagate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGLog::rewind_divergent_log is dereferencing iterator "p" though it is
already past the end of its container. When entering the loop for the
first time, p is log.log.end() and must not be dereferenced.
mark_dirty_from must only be called after p--. It
will not rewind past begin() because of the
if (p == log.log.begin())
test above.
http://tracker.ceph.com/issues/5398 fixes #5398
Signed-off-by: Loic Dachary loic@dachary.org