Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octopus: mgr/dashboard: Unable to edit iSCSI logged-in client #36611

Merged
merged 1 commit into from Aug 21, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Aug 13, 2020

backport tracker: https://tracker.ceph.com/issues/46924


backport of #36434
parent tracker: https://tracker.ceph.com/issues/46818

this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Fixes: https://tracker.ceph.com/issues/46818

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 7ee7fb9)
@tspmelo tspmelo requested a review from a team August 13, 2020 14:10
@tspmelo tspmelo requested a review from a team as a code owner August 13, 2020 14:10
@tspmelo tspmelo added this to the octopus milestone Aug 13, 2020
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could only review it and test whether the Dashboard module successfully runs because i was not able to connect to a iSCSI gateway with ceph-dev-vegrant or using a cluster with sesdev replace-mgr-modules ses7-mini --pr 36611.

@smithfarm
Copy link
Contributor

or using a cluster with sesdev replace-mgr-modules ses7-mini --pr 36611.

@votdev Could you try again with SUSE/sesdev#431 ?

@yuriw yuriw merged commit 00b0799 into ceph:octopus Aug 21, 2020
@tspmelo tspmelo deleted the wip-46924-octopus branch August 24, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants