client: unlock client_lock when copying data and do more check for the client_lock

[lxbsz]

Unlock client_lock when copying data to bufferlist And avoid using the client_lock.unlock/.lock directly if possible, and add more check for the client_lock.

Fixes: https://tracker.ceph.com/issues/47039
Fixes: https://tracker.ceph.com/issues/47047
Signed-off-by: Xiubo Li xiubli@redhat.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[batrick]

Otherwise LGTM

[lxbsz]

@batrick
Fixed them all, thanks.

[batrick]

/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:9756:9: error: no declaration matches 'int64_t Client::_preadv_pwritev_locked(Fh*, const iovec*, unsigned int, int64_t, bool, bool, std::unique_lock<ceph::mutex_debug_detail::mutex_debug_impl<false> >&)'
 9756 | int64_t Client::_preadv_pwritev_locked(Fh *fh, const struct iovec *iov,
      |         ^~~~~~
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:89:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note: candidate is: 'int64_t Client::_preadv_pwritev_locked(Fh*, const iovec*, unsigned int, int64_t, bool, bool)'
 1237 |   int64_t _preadv_pwritev_locked(Fh *f, const struct iovec *iov,
      |           ^~~~~~~~~~~~~~~~~~~~~~
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:89:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:230:7: note: 'class Client' defined here
  230 | class Client : public Dispatcher, public md_config_obs_t {
      |       ^~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc: In member function 'int Client::_preadv_pwritev(int, const iovec*, unsigned int, int64_t, bool)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:9819:75: error: no matching function for call to 'Client::_preadv_pwritev_locked(Fh*&, const iovec*&, unsigned int&, int64_t&, bool&, bool, std::unique_lock<ceph::mutex_debug_detail::mutex_debug_impl<false> >&)'
 9819 |     return _preadv_pwritev_locked(fh, iov, iovcnt, offset, write, true, cl);
      |                                                                           ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:89:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note: candidate: 'int64_t Client::_preadv_pwritev_locked(Fh*, const iovec*, unsigned int, int64_t, bool, bool)'
 1237 |   int64_t _preadv_pwritev_locked(Fh *f, const struct iovec *iov,
      |           ^~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note:   candidate expects 6 arguments, 7 provided
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc: In member function 'int64_t Client::ll_writev(Fh*, const iovec*, int, int64_t)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:13851:70: error: no matching function for call to 'Client::_preadv_pwritev_locked(Fh*&, const iovec*&, int&, int64_t&, bool, bool, std::unique_lock<ceph::mutex_debug_detail::mutex_debug_impl<false> >&)'
13851 |   return _preadv_pwritev_locked(fh, iov, iovcnt, off, true, false, cl);
      |                                                                      ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:89:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note: candidate: 'int64_t Client::_preadv_pwritev_locked(Fh*, const iovec*, unsigned int, int64_t, bool, bool)'
 1237 |   int64_t _preadv_pwritev_locked(Fh *f, const struct iovec *iov,
      |           ^~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note:   candidate expects 6 arguments, 7 provided
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc: In member function 'int64_t Client::ll_readv(Fh*, const iovec*, int, int64_t)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:13861:71: error: no matching function for call to 'Client::_preadv_pwritev_locked(Fh*&, const iovec*&, int&, int64_t&, bool, bool, std::unique_lock<ceph::mutex_debug_detail::mutex_debug_impl<false> >&)'
13861 |   return _preadv_pwritev_locked(fh, iov, iovcnt, off, false, false, cl);
      |                                                                       ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.cc:89:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note: candidate: 'int64_t Client::_preadv_pwritev_locked(Fh*, const iovec*, unsigned int, int64_t, bool, bool)'
 1237 |   int64_t _preadv_pwritev_locked(Fh *f, const struct iovec *iov,
      |           ^~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/client/Client.h:1237:11: note:   candidate expects 6 arguments, 7 provided
src/client/CMakeFiles/client.dir/build.make:62: recipe for target 'src/client/CMakeFiles/client.dir/Client.cc.o' failed
make[3]: *** [src/client/CMakeFiles/client.dir/Client.cc.o] Error 1
CMakeFiles/Makefile2:30648: recipe for target 'src/client/CMakeFiles/client.dir/all' failed

[lxbsz]

Sorry, the client.h changes still in the git stash, will update it soon.

[batrick]

https://pulpito.ceph.com/?branch=wip-pdonnell-testing-20200926.000836

failures known/unrelated.