Wip dang zipper 8 #36798
Wip dang zipper 8 #36798
Conversation
|
https://pulpito.ceph.com/dang-2020-08-25_14:52:18-rgw-wip-dang-zipper-8-distro-basic-smithi/ That's a lot of failures, but most of them are ragweed. I've verified that every other failure happened before this patch, so it's "clean" as far as that goes. |
dang
force-pushed
the
wip-dang-zipper-8
branch
2 times, most recently
from
65c3811
to
982d02b
Compare
| struct req_state rstate(req->cct, &rgw_env, req->get_user(), req->id); | ||
| struct req_state *s = &rstate; | ||
| struct req_state rstate(req->cct, &rgw_env, req->id); | ||
| struct req_state *s = req->get_state(); |
There was a problem hiding this comment.
can rstate be safely removed now?
| virtual int defer_gc(RGWObjectCtx *rctx, RGWBucket* bucket, RGWObject* obj, | ||
| optional_yield y) = 0; | ||
| virtual const RGWZoneGroup& get_zonegroup() = 0; | ||
| virtual int get_zonegroup(const string& id, RGWZoneGroup& zonegroup) = 0; |
There was a problem hiding this comment.
i'm not sure how much multisite configuration stuff we're gonna want under the store interface - especially if there's a future where the multisite configuration itself describes what kind of stores get constructed and used. maybe that deserves a separate interface outside of Store? something to think about
There was a problem hiding this comment.
Yeah, that may be. I'll start thinking about what that would look like. In the meantime, I'll move these APIs into zipper to help get rid of the ->getRados() calls.
- RGWGetObj and RGWPutObj Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
- zonegroup - obj policy Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
- read_usage Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
dang
force-pushed
the
wip-dang-zipper-8
branch
from
982d02b
to
be1e8e6
Compare
Zipper 8 - the zippening!
This has one major feature: it splits the RGWRadosStore into a separate set of files from RGWStore and company. It also has a lot of cleanup, removing API-breaking calls to getRados() and adding missing APIs.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox