rbd: fix default pool handling for krbd map/unmap #36854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default pool name does not get passed to the kernel since commit 96f05a7 ("rbd: delay determination of default pool name"). The kernel ends up interpreting the image name as the pool name (and the snapshot name as the image name). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
It is no longer a global variable, so rename the ones that have to do with options for unmapping (currently just "force"). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
|
The run isn't clean due to a kernel issue and, now that we connect to the cluster on "rbd map", an assert is triggered in the messenger on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken with #36380.