Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix style being applied globally #36865

Merged
merged 1 commit into from Sep 4, 2020
Merged

mgr/dashboard: fix style being applied globally #36865

merged 1 commit into from Sep 4, 2020

Conversation

ishanrai05
Copy link
Contributor

@ishanrai05 ishanrai05 commented Aug 28, 2020 •
edited

fixes: https://tracker.ceph.com/issues/45018

Signed-off-by: Ishan Rai ishanrai05@gmail.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@ishanrai05 ishanrai05 requested a review from a team as a code owner August 28, 2020 06:57
@ishanrai05
Copy link
Contributor Author

@tspmelo

@ishanrai05
Copy link
Contributor Author

before:
after

now:
before

@avanthakkar
Copy link
Contributor

jenkins test api

@avanthakkar avanthakkar added bug-fix dashboard skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology labels Aug 28, 2020
avanthakkar
avanthakkar approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tspmelo
Copy link
Contributor

tspmelo commented Aug 28, 2020

Could you also apply this to all other styles where this can happen?
The issue mentioned is not specific to modals.

@ishanrai05
Copy link
Contributor Author

@tspmelo sure, I will update the PR

tspmelo
tspmelo suggested changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be applied to other components.

@ishanrai05 ishanrai05 changed the title mgr/dashboard: fix style being applied globally in modal footer mgr/dashboard: fix style being applied globally Aug 31, 2020
@tspmelo
Copy link
Contributor

tspmelo commented Aug 31, 2020

I would suggest adding the component selector to all usages of ::ng-deep.

@ishanrai05
mgr/dashboard: fix style being applied globally
6189a62 
fixes: https://tracker.ceph.com/issues/45018

Signed-off-by: Ishan Rai <ishanrai05@gmail.com>
@LenzGr LenzGr requested a review from Exotelis September 2, 2020 09:12
@LenzGr LenzGr merged commit 7f21356 into ceph:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspmelo tspmelo tspmelo approved these changes

@votdev votdev votdev approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@Exotelis Exotelis Awaiting requested review from Exotelis

Assignees
No one assigned
Labels
bug-fix dashboard skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
None yet
Milestone
No milestone
5 participants
@ishanrai05 @avanthakkar @tspmelo @votdev @LenzGr